Add HeaderConfiguration XML decoding tests#32
Closed
VenkataKrishnaGarapati wants to merge 42 commits intomainfrom
Closed
Add HeaderConfiguration XML decoding tests#32VenkataKrishnaGarapati wants to merge 42 commits intomainfrom
VenkataKrishnaGarapati wants to merge 42 commits intomainfrom
Conversation
- Update Package.swift to swift-tools-version 6.0 - Use Swift 5 language mode for compatibility (full Swift 6 concurrency requires significant refactoring) - Bump iOS to 18.0+, tvOS to 18.0+, macOS to 15.0+ - Add .swiftlint.yml configuration for CI compliance - Update GitHub Actions workflow with modern setup - Update README with new CI badges and requirements - Update Kumo.podspec for version 3.0.0
- Remove CocoaPods installation instructions (CocoaPods support dropped in 3.0.0) - Update SPM to use branch reference until 3.0.0 is tagged - Update Carthage to use main branch - Add strict concurrency build check in CI - Fix nonisolated(unsafe) for static property in Service actor
- Update swift.yml to use Xcode 26.3 - Update carthage.yml to use Xcode 26.3 and iPhone 17 Pro (iOS 26.3) - Update README with Xcode 26.3 requirement
- Update Package.swift to use .swiftLanguageMode(.v6) for all targets - Add Sendable conformance to HTTP.Header - Add @unchecked Sendable to _Request struct - Add @unchecked Sendable to URLSession delegate classes - Use nonisolated(unsafe) for global mutable state - Add @sendable to closure parameters in Service - Fix BlobCache fetch method with UncheckedSendableBox for promise callbacks - All targets now compile with Swift 6 strict concurrency
- Xcode 26.3 does not exist on GitHub Actions runners - Use Xcode 16.2 which is available on macos-15 runners - Use iOS 18.2 simulator with iPhone 16
Swift 6 language mode produces warnings that may be treated as errors in certain CI environments. Keeping Swift 5 language mode with Swift 6 toolchain for now.
- Remove unused matrix configuration - Use default Xcode.app instead of specific version
feat: Swift 6 modernization for Kumo 3.0.0
master is not used, only main and develop.
- Remove -strict-concurrency=complete from swift-version-check job (strict concurrency produces warnings that are treated as errors on some CI runner Swift versions) - Remove Xcode version matrix from build-and-test, use runner default - Simplify workflow
- Update Package.swift to .swiftLanguageMode(.v6) for all targets - Add Xcode 26.3 selection to swift-version-check and build-and-test jobs - Concurrency fixes already in place from PR #26 merged changes
xcodebuild test exit code 70 may occur due to environment differences. Build validation is handled by swift build step.
- Update all CI runners from macos-15 to macos-26 - Update swift-tools-version from 6.0 to 6.2 - Update platform targets to .v26 (iOS, tvOS, macOS) - Remove || true from test step (proper runner fixes the issue) - Update README badges and requirements to reflect 26.x versions The test failure was caused by macos-15 runners (macOS 15.7.4) not matching the macOS 26 deployment target. macOS 26 runners have Xcode 26.3 with the correct SDK.
- Fix duplicate checkout and broken line in carthage.yml - Add 'brew install carthage' step for macos-26 runners
ci: remove master branch from workflow triggers
- Add Sendable to HTTP.ResponseStatus (enum with Int raw value) - Add Sendable to KumoLogger protocol - Add @unchecked Sendable to HTTPError (contains Any types) - Add @unchecked Sendable to CacheSerializationError/CacheDeserializationError - Add @unchecked Sendable to StorageAccessError - Add @unchecked Sendable to InMemory (GCD queue-based thread safety) - Restore -strict-concurrency=complete in CI workflow Build passes with zero concurrency warnings.
- Add @unchecked Sendable to StorageAccessError (contains Any) - Fix InMemory GCD closures: use nonisolated(unsafe) for weak self and type-erase generic D to Any before closure to avoid D.Type metatype capture warning - Result: zero concurrency warnings with -strict-concurrency=complete
…remaining - Fix weak var -> weak let in InMemory GCD closures (3 warnings) - Add doc comment to UncheckedSendableBox explaining why it exists - All 9 @unchecked Sendable usages audited and verified as required - Zero concurrency warnings with -strict-concurrency=complete
feat: enable strict concurrency checking
fix: exclude Info.plist files from SPM targets to eliminate build warnings
…cture - Generated Codable models from genspec HeaderConfiguration definitions - Added decoding tests for Atom feed and Configuration payload - Handled empty XML elements (Choices, ReadOnlyCriteria) - Sanitized XML structure to remove real eSOne identifiers - All tests passing
Author
|
Closing in favor of #33 which correctly targets ver/4.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.